Dusting off Solr MCP - WIP #3
Draft
+4,172
−162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I love the work! Just as an FYI, there was recently set up a https://github.com/apache/solr-mcp project, which has the same name. MCP is early days, and having multiple options is a good thing. I don't know if the name collision on In my perfect world, the MCP capabilities are just part of Solr so you don't need to install anything extra, but that isn't what we have in the short term, so having multiple options is a good thing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new
Dockerfilefor containerizing the application, updates thedocker-compose.ymlconfiguration, adds a new dependency, improves file handling in a script, and refactors a test script to use explicit configuration. Below is a breakdown of the most important changes:Containerization and Deployment
Dockerfileto containerize the application. This includes setting up a Python 3.10 environment, installing dependencies using Poetry, and defining environment variables for Solr and Ollama configurations. The application is set to run on port 8000. (Dockerfile, DockerfileR1-R33)docker-compose.ymlto specify the command for running the application inside the container. (docker-compose.yml, docker-compose.ymlR153)Dependency Management
aiohttpas a new dependency inpyproject.toml, which may be used for asynchronous HTTP requests. (pyproject.toml, pyproject.tomlR31)Script Improvements
process_markdown_filefunction to ensure the output directory exists before writing files, improving robustness. (scripts/process_markdown.py, scripts/process_markdown.pyR105-R109)Test Refactoring
simple_mcp_test.pyto use an explicitSolrConfigobject when initializingSolrClient, making the configuration more transparent and flexible. Commented out unused search-related code for future updates. (scripts/simple_mcp_test.py, [1] [2]